chore: remove usage of the prefer-global rules #11279
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didinele
requested review from
Jiralite,
SpaceEEC,
almeidx,
almostSouji,
ckohen,
kyranet,
monbrey and
sdanialraza
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11279 +/- ##
==========================================
- Coverage 44.97% 44.92% -0.06%
==========================================
Files 317 317
Lines 18222 18202 -20
Branches 1817 1815 -2
==========================================
- Hits 8196 8177 -19
+ Misses 10013 10012 -1
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qjuh
reviewed
Nov 17, 2025
Member
Qjuh
left a comment
Qjuh
left a comment
There was a problem hiding this comment.
including api-extractor in this change is correct
almeidx
reviewed
Nov 24, 2025
Member
almeidx
left a comment
almeidx
left a comment
There was a problem hiding this comment.
Can you update the eslint.config.js files in the templates for create-discord-bot too? Otherwise the linter will (probably) fail when people create a new project using it
didinele
force-pushed
the
chore/no-prefer-global
branch
from
1717188 to
1157f40
Compare
Jiralite
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should I have ignored api-extractor?
Closes #11272